Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
During client testing, it was observed that SALT annotation (e.g., /*3s) is correctly generated during Grammar Check, but disappears after clicking Submit. As a result, Add Morphemes later treats the word as correct (e.g., /3s), producing incorrect linguistic output.
What was changed
Updated the Submit functionality in audio_menu.py to preserve SALT annotations (e.g., /*3s) when inserting corrected sentences into the Convention Box.
Why it was changed
During client testing, it was observed that SALT annotations like /*3s were correctly generated during Grammar Check but disappeared after clicking Submit. This caused Add Morphemes to treat the word as correct (e.g., /3s), resulting in incorrect linguistic output.
How it was changed
Removed the use of removeErrorCoding() in the applyCorrection() function. Instead of cleaning the sentence, the corrected sentence is now inserted directly into the Convention Box while preserving the original SALT annotations.alities.